Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for the chat control #1631

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

FabienLelaquais
Copy link
Member

Related to doc#971.

  • Examples for the chat control
  • Example for the table control
  • Remove fallback hover text in Chat component
  • Hide JsonAdapter class
  • Minor fixes in reference and elements docs

- Example for the table control
- Remove fallback hover text in Chat component
- Hide JsonAdapter class
- Minor fixes in reference and elements docs
@FabienLelaquais FabienLelaquais added 📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 🟧 Priority: High Must be addressed as soon labels Aug 2, 2024
dinhlongviolin1
dinhlongviolin1 previously approved these changes Aug 2, 2024
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Avatar

@FabienLelaquais
Copy link
Member Author

FabienLelaquais commented Aug 2, 2024

Nice Avatar

These are Dall-E generated

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.1806650668495%

St.
Category Percentage Covered / Total
🟢 Statements
86.67% (-0.1% 🔻)
3063/3534
🟡 Branches
69.18% (-0.73% 🔻)
2018/2917
🟢 Functions
82.25% (-0.23% 🔻)
556/676
🟢 Lines
87.18% (-0.11% 🔻)
2836/3253
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
100% 91.3% 100% 100%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Chat.tsx
89.76% (-0.16% 🔻)
68.13% (-0.35% 🔻)
79.17%
91.13% (-0.14% 🔻)

Test suite run success

557 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 46cd587

namnguyen20999
namnguyen20999 previously approved these changes Aug 2, 2024
namnguyen20999
namnguyen20999 previously approved these changes Aug 5, 2024
Copy link
Member

@namnguyen20999 namnguyen20999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alice looks like she's from a superhero comic :D

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabienLelaquais FabienLelaquais merged commit 1ad66d6 into develop Aug 5, 2024
55 of 71 checks passed
@FabienLelaquais FabienLelaquais deleted the doc/doc#971-chat-control-doc branch August 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants